Template talk:High-use: Difference between revisions

By /

Line 150: Line 150:

|} [[User:FaviFake|FaviFake]] ([[User talk:FaviFake|talk]]) 18:33, 11 October 2025 (UTC)

|} [[User:FaviFake|FaviFake]] ([[User talk:FaviFake|talk]]) 18:33, 11 October 2025 (UTC)

:Example of two templates looking the same in the /doc: {{Tl|Clickable button}} [[User:FaviFake|FaviFake]] ([[User talk:FaviFake|talk]]) 18:53, 11 October 2025 (UTC)

:Example of two templates looking the same in the /doc: {{Tl|Clickable button}} [[User:FaviFake|FaviFake]] ([[User talk:FaviFake|talk]]) 18:53, 11 October 2025 (UTC)

::Please link to the discussion that prompted the use of {{tl|tper}} here. The template is for edit requests that are uncontroversial or supported by consensus. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:11, 11 October 2025 (UTC)

Instead of just taking the number of transclusions and dividing by {{NUMBEROFPAGES}} (which is currently 63,227,481), I was thinking it might make for a more cautionary warning to also show how big the number is compared to {{NUMBEROFARTICLES}}. See [1] for the sandboxed change. Basically, this would cause the template to look like this:

Naturally, not all templates that use {{High-use}} are used in mainspace, so I can see how this change could be a little confusing, but I think it would still make the percent number more meaningfully cautionary. For example, Template:Short description says that the template is used on “10% of all pages”, which honestly feels like not a big number—it would more clearly impress upon the layperson the gravity of the situation if it said “92% of all mainspace articles”. Template:WikiProject banner shell would say: “This template is used on approximately 11,300,000 pages, which is roughly 161% of all mainspace articles or 18% of all pages.” Mz7 (talk) 06:50, 29 May 2025 (UTC)[reply]

@Mz7 I’m worried that would be a bit misleading, as it would result in things like {{WikiProject banner shell}} saying that it’s being used on 163% of mainspace articles. If there’s a strong desire to include this information I could look into having Ahechtbot tabulate mainspace transclusions in addition to all transclusions, but that would cause a significant increase in runtime and require breaking changes to the data pages. —Ahecht (TALK
PAGE) 18:13, 29 August 2025 (UTC)[reply]

Just adding that I already did this experiment back in 2021, and running the transclusion count query limited to the article namespace wasn’t feasible (it just sat there for three hours before timing out, compared to 10-20 minutes for the all-namespace query). —Ahecht (TALK
PAGE) 18:54, 10 October 2025 (UTC)[reply]

There are a few high-use template styles, e.g., Template:Sister project/styles.css, which have no such indication (as they do not have documentation subpages). In my own private wiki, I have provided an analogous notice via the top icon indicator as these are still processed within CSS comments. My Module:High-use has been changed as follows: 

local function showIndicator()
	return mw.getCurrentFrame():preprocess([=[
{{#tag:indicator|<span class="plainlinks" style="background-color:pink;">[[WP:High-risk templates|High-use]]:[https://linkcount.toolforge.org/?project=en.wikipedia.org&page={{urlencode:{{FULLPAGENAME}}}}#transclusions {{#invoke:transclusion count|fetch}}]</span>|name=High-use}}]=])
end

function p._main(args, nocat)
	local contentModel = mw.title.getCurrentTitle().contentModel
	if contentModel == "css" or contentModel == "sanitized-css" then
		return showIndicator()
	end
-- remainder of function

If you think this is useful on Wikipedia, I can make the associated changes for all but non-admin protected pages.
Dpleibovitz (talk) 17:14, 16 July 2025 (UTC)[reply]

Description of suggested change: I’ve refactored the module code to make it:

  • easier to understand (added comments)
  • easier to localize
  • have less repeated code
  • use |demo= as the title everywhere, including in the Toolforge link, if provided
  • use the base page for /testcases pages as well as /doc and /sandbox
  • use Lua for the system categorization code instead of preprocessing a string containing {{sandbox other}}, a switch statement, and a Module:Effective protection level invocation

My code is in Module:High-use/sandbox and the test cases are at Template:High-use/testcases. Please check my code and update the main module if it looks good!

Diff:
sandbox diff
—CalendulaAsteraceae (talk • contribs) 08:28, 27 August 2025 (UTC)[reply]

Answering your post at Wikipedia:Village pump (technical) § Code review for Module:High-use refactor here because this is a better venue.
Add require ('strict') which will help find globals that ought not be globals, etc.
For i18n, consider rewriting count_from_args() (lines 18–36 – permalink); mayhaps sommat like this:

require ('strict');

local lang_obj = mw.getContentLanguage()										-- this here because the language object is used multiple places in the module

local function count_from_args(args_t)
	if tonumber(args_t.count) then												-- check if function has already been used
		return count;															-- early exit if already used
	end

	local count;	

	if count == nil and yesno(args_t['fetch']) == true then						-- '== true' instead of '~= false'
		count = _fetch(args_t)													-- fetch transclusion count
	end
	
	if count == nil and args_t[1] ~= nil and args_t[1] ~= '' then				-- use explicitly-provided count when fetch fails
		count = math.floor (lang_obj:parseFormattedNumber (args_t[1]));			-- convert local language number string to a number understandable by lua
	end
	
	return count > 0 and count or nil;											-- incase someone writes a negative number
end
—Trappist the monk (talk) 16:35, 29 August 2025 (UTC)[reply]

Thank you, implemented! I think the current code does use _fetch if args['fetch'] is nil, so I’ve left that as-is. —CalendulaAsteraceae (talk • contribs) 21:25, 29 August 2025 (UTC)[reply]
It looks like you’ve implemented hooks to show percentage of articles in addition to all pages. See the section above for my concerns there. We can tabulate mainspace usage separately with the bot, but it’s not worth the effort unless there’s actual consensus to include it. —Ahecht (TALK
PAGE) 19:09, 29 August 2025 (UTC)[reply]

TBH I just left that in because someone else had been working on it, no problem to take that out. —CalendulaAsteraceae (talk • contribs) 21:20, 29 August 2025 (UTC)[reply]
@Ahecht, @Trappist the monk, how does the updated code look? —CalendulaAsteraceae (talk • contribs) 03:45, 14 September 2025 (UTC)[reply]

@CalendulaAsteraceae My only concern is using the base page name for the sandbox. There are sub-templates that are listed in Module:Transclusion_count/data/ that likely have their own sandboxes. For example, the “high use” message at Module:Adjacent stations/Amtrak correctly links to Module:Adjacent stations/Amtrak/sandbox. For the sandbox, the existing logic that only uses the basePageTitle if it ends in “doc” or “sandbox” is fine. For the testcases, I might see an argument to strip “doc” and “sandbox”, check if that testcases page exists (although I’d do it with getContent() since for some reason exists is expensive but getContent() isn’t), and if not use the base page title. —Ahecht (TALK
PAGE) 15:39, 14 September 2025 (UTC)[reply]

@Ahecht, done. —CalendulaAsteraceae (talk • contribs) 03:34, 15 September 2025 (UTC)[reply]
@Ahecht, thoughts on the updated code? —CalendulaAsteraceae (talk • contribs) 21:54, 3 October 2025 (UTC)[reply]

@CalendulaAsteraceae The testcases look fine to me. I haven’t had a chance to dive into the code, but if you’re willing to take ownership then go for it. —Ahecht (TALK
PAGE) 18:49, 4 October 2025 (UTC)[reply]

@Ahecht: Thank you! I don’t have permissions to edit Module:High-use, but if you copy over my latest edits at Module:High-use/sandbox, I’m happy to keep an eye on things and fix any issues that come up. —CalendulaAsteraceae (talk • contribs) 05:27, 5 October 2025 (UTC)[reply]
 Done —Ahecht (TALK
PAGE) 13:57, 7 October 2025 (UTC)[reply]

Thank you! —CalendulaAsteraceae (talk • contribs) 21:53, 7 October 2025 (UTC)[reply]

Transcluding nonexistent /testcases pages

This change appears to have caused {{Taxonomy/Salticidae}} to transclude {{Taxonomy/Salticidae/testcases}}, which does not exist. This new issue is happening at a few hundred or more Taxonomy templates. See Wikipedia:Database reports/Transclusions of non-existent templates for the list. It is also happening at some non-Taxonomy templates, like {{Tab/Number of defined parameters}}. – Jonesey95 (talk) 18:09, 8 October 2025 (UTC)[reply]

We can fix that by using exists instead of getContent. I think that’ll be OK even though it’s an expensive function, since the template is only called once per page, and Template:High-use/testcases is fine even though it calls the template a lot. @Ahecht, could you copy over my changes from Module:High-use/sandbox? —CalendulaAsteraceae (talk • contribs) 20:20, 8 October 2025 (UTC)[reply]
 Done —Ahecht (TALK
PAGE) 20:24, 8 October 2025 (UTC)[reply]

It looks like that worked. There are about half a dozen fully protected pages still causing /testcases transclusions to show up on the report, but they will clear on their own. – Jonesey95 (talk) 16:00, 9 October 2025 (UTC)[reply]
It’s also fixed Wikipedia:Database reports/Broken WikiProject templates. —Redrose64 🌹 (talk) 16:06, 10 October 2025 (UTC)[reply]

Description of suggested change: can we get a |testcase= that will allow you to supply a link to where the testcases are located that will replace the default of ''base_template''/testcase? The reason for this is Modules. The testcases cannot be located at Module:Person height/testcases (for example) and are more likely to be located at Template:Infobox person/height/testcases. —Zackmann (Talk to me/What I been doing) 08:42, 27 September 2025 (UTC)[reply]

Actually they can be located at Module:Person height/testcases; you can use Special:ChangeContentModel to create a wikitext page there, or move an existing wikitext page there (and click through the edit filter warning). I’d be more inclined to just do so and create a redirect rather than convoluting up the template, but if another TPE wants to code and implement this I guess they can do so. * Pppery * it has begun… 16:24, 27 September 2025 (UTC)[reply]

@Pppery: well… You learn something new everyday! Thanks a ton. Didn’t know about Change Context Model. — Zackmann (Talk to me/What I been doing) 18:21, 27 September 2025 (UTC)[reply]

@Zackmann08 You don’t even have to change the content model. The default used by the {{documentation}} template (used by nearly all modules) is to locate the testcases at Module:Foo/testcases, and it prepopulates that module page with Template:Documentation/preload-module-testcases which uses Module:UnitTests to create the testcases. You then run it by going to Module talk:Foo/testcases. —Ahecht (TALK
PAGE) 18:55, 27 September 2025 (UTC)[reply]

@Ahecht: that seems complicated…[sarcasm]. Thanks for the info though!!! —Zackmann (Talk to me/What I been doing) 19:03, 27 September 2025 (UTC)[reply]

There is a discussion over at Template talk:Used in system#documentation out of date? you might be interested in. Regards CapnZapp (talk) 11:05, 5 October 2025 (UTC)[reply]

The icon for the {{Used in system}} is generic so it can be confused with any other warnings hardcoded in the /doc, even though the fact that a template is used in system messages is very important. I think it should at least use the same icon as {{High-use}} when set to |risk= to better catch the attention of editors used to seeing a riangular warning for templates that have many transclusions.

Line Module:High-use § L-218 should be changed to:

Line 216: Line 216:
if args[‘system’] and args[‘system’] ~= ” then if args[‘system’] and args[‘system’] ~= ” then
image=”Ambox important.svg” image=”Ambox .svg”
type_param = ‘content’ type_param = ‘content’
if yesno(nocat or args[‘nocat’]) ~= true and not args.title.isRedirect then if yesno(nocat or args[‘nocat’]) ~= true and not args.title.isRedirect then

FaviFake (talk) 18:33, 11 October 2025 (UTC)[reply]

Example of two templates looking the same in the /doc: {{Clickable button}} FaviFake (talk) 18:53, 11 October 2025 (UTC)[reply]

Please link to the discussion that prompted the use of {{tper}} here. The template is for edit requests that are uncontroversial or supported by consensus. – Jonesey95 (talk) 20:11, 11 October 2025 (UTC)[reply]

Must Read

Leave a Comment

Your email address will not be published. Required fields are marked *

Scroll to Top