Template talk:MergedMap: Difference between revisions

Line 31: Line 31:

:::@[[User:Joy|Joy]] Hi, No! There is no typo. I applied both ‘label’ or ‘MegedMap_label’ in [https://en.wikipedia.org/w/index.php?title=Template%3AMergedMap%2Fdoc&diff=1324410002&oldid=1324408971 this edit] and it works well. Please inspect. Thanks, [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 12:44, 27 November 2025 (UTC)

::::I mean the string “MegedMap_label” contains the word “Meged” that is missing a r to be “Merged” 🙂 –[[User:Joy|Joy]] ([[User talk:Joy|talk]]) 12:46, 27 November 2025 (UTC)

:::::{{Done}} [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 12:52, 27 November 2025 (UTC)

::::Can you move these examples to test cases, please? –[[User:Joy|Joy]] ([[User talk:Joy|talk]]) 12:46, 27 November 2025 (UTC)

First of all, nice work @Hooman Mallahzadeh, it looks very promising. I will proceed to ask some questions now, though 🙂

For some reason, the template includes:

|coordinates = {{#invoke:coordinates|coord2text|{{#:property:625}}}}

Why would we force the Wikidata property reading, why not take coordinates as an argument? That would sound more in line with the preference for local data whenever we need to override it. —Joy (talk) 16:27, 26 November 2025 (UTC)[reply]

@Joy You are right! I corrected that with this edit. “coordinates” argument is really needed for test-cases, but I think Wikidata coordinates is a good choice for the default behavior. Thanks. Hooman Mallahzadeh (talk) 16:35, 26 November 2025 (UTC)[reply]

For some reason, the template includes:

|label = {{#ifeq: {{lc: {{{pushpin_label_position|}}} }} | none | | {{#if:{{{pushpin_label|}}}|{{{pushpin_label}}}|{{if empty|{{{name|}}}|{{{official_name|}}}|{{PAGENAMEBASE}}}}}} }}

Why are we taking pushpin_label* and name and official name parameters here, is this meant to take stuff from infobox settlement? (What if the pushpin label describes only one of the maps, but not all?) —Joy (talk) 16:30, 26 November 2025 (UTC)[reply]

You are right! I corrected that with this edit. Thanks again. Hooman Mallahzadeh (talk) 16:43, 26 November 2025 (UTC)[reply]

BTW ‘MegedMap_label’ has a typo, and it combines camelcase with snake case.

At the same time, I still don’t quite get the point. Is this supposed to match Module:MergedMap#L-76 args.label?

This seems to be another case of passing things down to a child data source, but only passing one variable instead of many. —Joy (talk) 12:33, 27 November 2025 (UTC)[reply]

@Joy Hi, No! There is no typo. I applied both ‘label’ or ‘MegedMap_label’ in this edit and it works well. Please inspect. Thanks, Hooman Mallahzadeh (talk) 12:44, 27 November 2025 (UTC)[reply]

I mean the string “MegedMap_label” contains the word “Meged” that is missing a r to be “Merged” 🙂 —Joy (talk) 12:46, 27 November 2025 (UTC)[reply]

Done Hooman Mallahzadeh (talk) 12:52, 27 November 2025 (UTC)[reply]

Can you move these examples to test cases, please? —Joy (talk) 12:46, 27 November 2025 (UTC)[reply]

I noticed these as well:

|zoom = {{{mapframe-zoom|}}}|marker = {{{mapframe-marker|}}}|shape = {{{mapframe-shape|}}}

Why not take all of the mapframe arguments instead of just these three? —Joy (talk) 16:31, 26 November 2025 (UTC)[reply]

These should be added gradually, one by one. But I think these three are the main ones which have been used extensively. Others are not so important. Hooman Mallahzadeh (talk) 16:39, 26 November 2025 (UTC)[reply]

I don’t agree, if we know that these parameters exist, and that editors are using them, why not support them to make things easy for them? —Joy (talk) 12:27, 27 November 2025 (UTC)[reply]

This template name is CamelCase, unlike the style of {{maplink}}, {{mapframe}}, {{location map}}.

The name also reflects a state that isn’t future-proof – if we make this a standard, then people won’t really know of non-merged maps 🙂

I’d go with something simple like {{multiple maps}} or even {{map choice}} / {{frame choice}} instead. —Joy (talk) 12:21, 27 November 2025 (UTC)[reply]

@Joy I am really agree with you! This name is not good at all. But what do you propose for its name? I propose Template:OverlayedMaps and ‘overlayMapsQuery’ instead. Hooman Mallahzadeh (talk) 12:48, 27 November 2025 (UTC)[reply]

In the last sentence above, I proposed three posibilities.

I don’t know that overlayed – or rather, overlaid – is useful enough here. It implies some sort of combination, not just a choice. —Joy (talk) 12:51, 27 November 2025 (UTC)[reply]

I wouldn’t call the mapframe item just “OSM” because:

that’s a somewhat obscure acronym for the general reader
it doesn’t actually visually look like the default openstreetmap.org style
the technical implementation is more complex than just OSM – meta:Wikimedia Maps is the name over there, but that in turn seems not very informative

The phrase “Interactive map” seems better.

Likewise, I wouldn’t use pushpin map labels without an indication that it’s a pushpin map.

Maybe prefix or suffix them with “pushpin map”?

(“Location map” would match {{location map}} better but it’s too generic in this context, because other maps are also ‘location maps’.)

—Joy (talk) 12:24, 27 November 2025 (UTC)[reply]

Must Read

Leave a Comment Cancel Reply